junitlauncher - Support useFile attribute for listeners#171
junitlauncher - Support useFile attribute for listeners#171azotcsit wants to merge 1 commit intoapache:masterfrom
Conversation
|
Hello @azotcsit, the |
|
Hi @jaikiran, I'm new to this codebase, so I'm sorry if I missed something. If we talk hypothetically then not only I feel the current design mixes up
I agree that it can decide, but according to the current design it is supposed to use With that being said, I have some questions. The answers would help me to understand what changes to bring back to ant and what to keep in custom foratters. Also it will probably prevent me of raising controversial tickets like this one. Architectural questions:
That should help to keep listeners and Other questions:
Sorry for bugging you with so many questions 😄 |
372bc1a to
f72b116
Compare
Context
I'm working on migration of Cassandra to JUnit5 (https://issues.apache.org/jira/browse/CASSANDRA-16630). Our test running code is heavily customized and one of the features we rely on is "useFile" attribute (https://github.com/apache/ant/blob/master/src/main/org/apache/tools/ant/taskdefs/optional/junit/FormatterElement.java#L80). Unfortunately, junitlauncher task does not have any equivalent. The purpose of this change is to introduce a way to write listener's output to
stdoutinstead of a file.Behavior
This PR does not change any existing behavior.
Summary of the changes
useFileattribute forListenerDefinitionLauncherSupportto supper the new attribute